== Series Details == Series: series starting with [01/23] drm/i915: Reduce context HW ID lifetime URL : https://patchwork.freedesktop.org/series/49157/ State : warning == Summary == $ dim checkpatch origin/drm-tip d7ddd5a81ce5 drm/i915: Reduce context HW ID lifetime -:61: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #61: FILE: drivers/gpu/drm/i915/i915_drv.h:1864: + struct mutex mutex; total: 0 errors, 0 warnings, 1 checks, 433 lines checked 12f688340874 drm/i915/execlists: Avoid kicking priority on the current context -:49: ERROR:SPACING: space prohibited after that open parenthesis '(' #49: FILE: drivers/gpu/drm/i915/intel_guc_submission.c:774: + if ( __guc_dequeue(engine)) total: 1 errors, 0 warnings, 0 checks, 103 lines checked 0dc2e7376733 drm/i915: Missed interrupt simulation is no more, tell the world 3612d9a0f807 drm/i915/selftests: Basic stress test for rapid context switching -:120: WARNING:ALLOC_ARRAY_ARGS: kcalloc uses number as first arg, sizeof is generally wrong #120: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:127: + ctx = kcalloc(sizeof(*ctx), nctx, GFP_KERNEL); total: 0 errors, 1 warnings, 0 checks, 203 lines checked c57b5226773f drm/i915/execlists: Delay updating ring register state after resume -:68: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #68: FILE: drivers/gpu/drm/i915/intel_lrc.c:2891: + ce->lrc_reg_state[CTX_RING_HEAD+1] = 0; ^ -:69: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #69: FILE: drivers/gpu/drm/i915/intel_lrc.c:2892: + ce->lrc_reg_state[CTX_RING_TAIL+1] = 0; ^ total: 0 errors, 0 warnings, 2 checks, 52 lines checked eded3ed0adbe drm/i915/execlists: Use coherent writes into the context image -:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #56: FILE: drivers/gpu/drm/i915/i915_perf.c:1851: + regs = i915_gem_object_pin_map(ce->state->obj, + i915_coherent_map_type(dev_priv)); total: 0 errors, 0 warnings, 1 checks, 71 lines checked 47868ad3229b drm/i915/execlists: Onion unwind for logical_ring_init() failure 3d1e691c76dc drm/i915: Report the number of closed vma held by each context in debugfs -:43: WARNING:LONG_LINE: line over 100 characters #43: FILE: drivers/gpu/drm/i915/i915_debugfs.c:350: + seq_printf(m, "%s: %lu objects, %llu bytes (%llu active, %llu inactive, %llu global, %llu shared, %llu unbound, %llu closed)\n", \ total: 0 errors, 1 warnings, 0 checks, 169 lines checked 76d02ab168e3 drm/i915: Remove debugfs/i915_ppgtt_info 85f92b3ad0b5 drm/i915/execlists: Assert the queue is non-empty on unsubmitting -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: <0>[ 531.960431] drv_self-4806 7.... 527402570us : intel_gpu_reset: engine_mask=1, ret=0, retry=0 total: 0 errors, 1 warnings, 0 checks, 7 lines checked 79bd577c5774 drm/i915: Handle incomplete Z_FINISH for compressed error states 0c32e06efa4a drm/i915: Clear the error PTE just once on finish fa0b7f94b44a drm/i915: Cache the error string f5e5e1732bd4 drm/i915: Attach the pci match data to the device upon creation -:83: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #83: FILE: drivers/gpu/drm/i915/i915_drv.c:1353: + BUG_ON(device_info->gen > sizeof(device_info->gen_mask) * BITS_PER_BYTE); total: 0 errors, 1 warnings, 0 checks, 107 lines checked c8b527abd7f5 drm/i915: Track all held rpm wakerefs -:105: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #105: FILE: drivers/gpu/drm/i915/i915_drv.h:1293: + spinlock_t debug_lock; total: 0 errors, 0 warnings, 1 checks, 571 lines checked 0e5cd2856b69 drm/i915: Markup paired operations on wakerefs -:707: WARNING:NEW_TYPEDEFS: do not add new typedefs #707: FILE: drivers/gpu/drm/i915/i915_drv.h:130: +typedef depot_stack_handle_t intel_wakeref_t; total: 0 errors, 1 warnings, 0 checks, 1970 lines checked 011f0dab532a drm/i915: Syntatic sugar for using intel_runtime_pm -:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #491: FILE: drivers/gpu/drm/i915/intel_drv.h:2062: +#define with_intel_runtime_pm(i915, wf) \ + for (wf = intel_runtime_pm_get(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) -:491: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #491: FILE: drivers/gpu/drm/i915/intel_drv.h:2062: +#define with_intel_runtime_pm(i915, wf) \ + for (wf = intel_runtime_pm_get(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) -:495: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #495: FILE: drivers/gpu/drm/i915/intel_drv.h:2066: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) -:495: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #495: FILE: drivers/gpu/drm/i915/intel_drv.h:2066: +#define with_intel_runtime_pm_if_in_use(i915, wf) \ + for (wf = intel_runtime_pm_get_if_in_use(i915); wf; \ + intel_runtime_pm_put(i915, wf), wf = 0) total: 0 errors, 0 warnings, 4 checks, 569 lines checked 1f950437390d drm/i915: Markup paired operations on display power domains -:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #31: FILE: drivers/gpu/drm/i915/i915_debugfs.c:634: + wakeref = intel_display_power_get_if_enabled(dev_priv, + power_domain); total: 0 errors, 0 warnings, 1 checks, 1400 lines checked bfb58f028bc8 drm/i915: Track the wakeref used to initialise display power domains -:207: WARNING:LINE_SPACING: Missing a blank line after declarations #207: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:4112: + struct i915_power_domains *power_domains = &i915->power_domains; + intel_wakeref_t wakeref __maybe_unused = -:224: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->csr.dmc_payload" #224: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:4126: + i915->csr.dmc_payload != NULL) { total: 0 errors, 1 warnings, 1 checks, 320 lines checked d467de58f069 drm/i915/dp: Markup pps lock power well -:50: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dp' - possible side-effects? #50: FILE: drivers/gpu/drm/i915/intel_dp.c:681: +#define with_pps_lock(dp, wf) \ + for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf)) -:50: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wf' - possible side-effects? #50: FILE: drivers/gpu/drm/i915/intel_dp.c:681: +#define with_pps_lock(dp, wf) \ + for (wf = pps_lock(dp); wf; wf = pps_unlock(dp, wf)) total: 0 errors, 0 warnings, 2 checks, 423 lines checked 0815d4eecb58 drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice 318b8a7e9da4 drm/i915: Mark up Ironlake ips with rpm wakerefs -:210: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #210: FILE: drivers/gpu/drm/i915/intel_pm.c:7970: + chipset_val = graphics_val = 0; total: 0 errors, 0 warnings, 1 checks, 318 lines checked 839f4ddf3d71 drm/i915: Serialise concurrent calls to i915_gem_set_wedged() -:48: WARNING:MEMORY_BARRIER: memory barrier without comment #48: FILE: drivers/gpu/drm/i915/i915_gem.c:3403: + smp_mb__before_atomic(); total: 0 errors, 1 warnings, 0 checks, 107 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
