On Mon, Sep 03, 2018 at 06:38:44PM +0100, Emil Velikov wrote: > On 3 September 2018 at 17:54, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > > > -Hide legacy cruft better > > ------------------------- > > - > > -Way back DRM supported only drivers which shadow-attached to PCI devices with > > -userspace or fbdev drivers setting up outputs. Modern DRM drivers take charge > > -of the entire device, you can spot them with the DRIVER_MODESET flag. > > - > > -Unfortunately there's still large piles of legacy code around which needs to > > -be hidden so that driver writers don't accidentally end up using it. And to > > -prevent security issues in those legacy IOCTLs from being exploited on modern > > -drivers. This has multiple possible subtasks: > > - > > > -* Extract support code for legacy features into a ``drm-legacy.ko`` kernel > > - module and compile it only when one of the legacy drivers is enabled. > > - > This isn't done, Yup, but I kinda figured I'll give up on this idea. The code is hidden well enough, I don't think a drm-legacy.ko will buy us much. Except lots of churn on older driver's Kconfig entries for no purpose. There's been a patch already a while back to hide the legacy drivers better, and Dave nacked it. So I'm not really for pushing this idea anymore as a good task for newbies (which todo.rst tries to collect). Want me to explain this a bit better in the commit message? -Daniel > > > -This is mostly done, the only thing left is to split up ``drm_irq.c`` into > > -legacy cruft and the parts needed by modern KMS drivers. > > - > ... while this one is. > > HTH > -Emil -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
