Yeah, Thanks for the "Acked-by" Rodrigo.
I request Imre/Anusha to review/acknowledge the same.
Regards
Jyoti
-----Original Message-----
From: Vivi, Rodrigo
Sent: Tuesday, September 4, 2018 11:02 AM
To: Yadav, Jyoti R <jyoti.r.yadav@xxxxxxxxx>
Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] [intel-gfx] drm/i915/intel_csr.c Added ICL Stepping info.
On Mon, Sep 03, 2018 at 03:45:13AM -0400, Jyoti Yadav wrote:
> As DMC Package contain DMC FW for multiple steppings including default
> stepping. This patch will help to load FW for that particular
> stepping, if FW for that stepping is available, instead of loading default FW.
>
Cc: Imre Deak <imre.deak@xxxxxxxxx>
Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> Signed-off-by: Jyoti Yadav <jyoti.r.yadav@xxxxxxxxx>
I'm not sure if I can properly review this, but based on previous platforms patch lgtm.
Acked-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
I'm just not pushing because I'd like an ack from Anusha and/or Imre.
> ---
> drivers/gpu/drm/i915/intel_csr.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c
> b/drivers/gpu/drm/i915/intel_csr.c
> index 1ec4f09..f6352ab 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -183,6 +183,11 @@ struct stepping_info {
> {'A', '0'}, {'A', '1'}, {'A', '2'},
> {'B', '0'}, {'B', '1'}, {'B', '2'}
> };
nip by checkpatch: missing blank line here.
> +static const struct stepping_info icl_stepping_info[] = {
> + {'A', '0'}, {'A', '1'}, {'A', '2'},
> + {'B', '0'}, {'B', '2'},
> + {'C', '0'}
> +};
>
> static const struct stepping_info no_stepping_info = { '*', '*' };
>
> @@ -198,6 +203,9 @@ struct stepping_info {
> } else if (IS_BROXTON(dev_priv)) {
> size = ARRAY_SIZE(bxt_stepping_info);
> si = bxt_stepping_info;
> + } else if (IS_ICELAKE(dev_priv)) {
> + size = ARRAY_SIZE(icl_stepping_info);
> + si = icl_stepping_info;
> } else {
> size = 0;
> si = NULL;
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
