Re: [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 29, 2018 at 11:32:35AM +0100, Chris Wilson wrote:
> Quoting Lucas De Marchi (2018-08-29 01:35:31)
> > The 2 PCI IDs that are used for the command line overrid mechanism
> > were left defined.
> 
> What makes them so special? Why not just match on the override devid?

because it's a name -> id mapping? It maps a short string like "skl" to
a single specific PCI ID... how useful is that and if we should retain
its behavior, I have dunno. But
i915_pciids.h doesn't have defines for individual PCI IDs, but groups of
them.

I would either have to create an accessor/iter for gen x in
intel_chipset.c or do some macros to extract the first id from the
i915_pciids.h, just to get an ID that is set in stone and change the
current id used :-/

Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux