Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
> Having stored the IIR for action, we should always clear it.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
As getting stray unexpected intrs usually is
driver vs hw misconfiguration, should we at some point
start to complain if we see one?
Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 90628a47ae17..e37e3ec22a79 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1534,11 +1534,8 @@ static void gen8_gt_irq_ack(struct drm_i915_private *i915,
>
> if (master_ctl & (GEN8_GT_PM_IRQ | GEN8_GT_GUC_IRQ)) {
> gt_iir[2] = raw_reg_read(regs, GEN8_GT_IIR(2));
> - if (likely(gt_iir[2] & (i915->pm_rps_events |
> - i915->pm_guc_events)))
> - raw_reg_write(regs, GEN8_GT_IIR(2),
> - gt_iir[2] & (i915->pm_rps_events |
> - i915->pm_guc_events));
> + if (likely(gt_iir[2]))
> + raw_reg_write(regs, GEN8_GT_IIR(2), gt_iir[2]);
> }
>
> if (master_ctl & GEN8_GT_VECS_IRQ) {
> --
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
