Re: [PATCH i-g-t 3/4] trace.pl: Bring back timeline stacking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27/07/2018 22:47, John Harrison wrote:
On 7/19/2018 2:36 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin<tvrtko.ursulin@xxxxxxxxx>

Bring back the button which expands/stacks overlapping timeline boxes.

We default to no stacking, but sometimes expanding the view can be useful,
especially with deep request pipelines.

Signed-off-by: Tvrtko Ursulin<tvrtko.ursulin@xxxxxxxxx>
---
  scripts/trace.pl | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index 59f6d32dc3c8..1924333e12b6 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -935,6 +935,7 @@ Boxes are in format 'ctx-id/seqno'.
  <p>
  Use Ctrl+scroll-action to zoom-in/out and scroll-action or dragging to move around the timeline.
  </p>
+<button onclick="toggleStacking()">Toggle overlap stacking</button>
  </td>
  </tr>
  </table>
@@ -1284,6 +1285,12 @@ print <<ENDHTML;
// Create a Timeline
    var timeline = new vis.Timeline(container, items, groups, options);
+
+  function toggleStacking() {
+	options.stack = !options.stack;
+	options.stackSubgroups = !options.stackSubgroups;
+	timeline.setOptions(options);
+  }
  ENDHTML
print <<ENDHTML;

Reviewed-by: John Harrison <John.C.Harrison@xxxxxxxxx>

Pushed up to this one, thanks! (BTW this reply even patchwork did not see. But it saw your replies to 1 & 2.)

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux