Quoting Paulo Zanoni (2018-08-01 00:45:04)
> +static bool icl_tc_phy_connect(struct drm_i915_private *dev_priv,
> + struct intel_digital_port *dig_port)
> +{
> + enum tc_port tc_port = intel_port_to_tc(dev_priv, dig_port->base.port);
> + u32 val;
> +
> + if (dig_port->tc_type != TC_PORT_LEGACY &&
> + dig_port->tc_type != TC_PORT_TYPEC)
> + return true;
> +
> + val = I915_READ(PORT_TX_DFLEXDPPMS);
> + if (!(val & DP_PHY_MODE_STATUS_COMPLETED(tc_port))) {
> + DRM_ERROR("DP PHY for TC port %d not ready\n", tc_port);
> + return false;
This is going to be hit as soon as someone manages to plug&unplug the
cable rapidly enough, The callers all handle the bool return so why
proclaim error on their behalf?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
