== Series Details == Series: drm/i915: Interactive RPS mode (rev5) URL : https://patchwork.freedesktop.org/series/46334/ State : warning == Summary == $ dim checkpatch origin/drm-tip 93827b4e697a drm/i915: Interactive RPS mode -:27: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e9af4ea2b9e7 ("drm/i915: Avoid waitboosting on the active request")' #27: full throttle and upclock the GPU to max. But in commit e9af4ea2b9e7, we -:124: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #124: FILE: drivers/gpu/drm/i915/i915_drv.h:785: + struct mutex mutex; -:139: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #139: FILE: drivers/gpu/drm/i915/i915_drv.h:3431: +extern void intel_rps_mark_interactive(struct drm_i915_private *i915, total: 1 errors, 0 warnings, 2 checks, 257 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx