Re: [igt-dev] [PATCH i-g-t v6 2/4] lib/igt_pm: Find HDA device when attempting to enable runtime PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2018-07-24 11:29:31)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> HDA audio device can be present at various PCI paths on different systems
> which the existing code did not account for.
> 
> Furthermore the failure to enable runtime PM was silent leaving callers
> in the dark.
> 
> Improve it by auto-locating the PCI path and logging a warning when
> something is not as expected.
> 
> v2:
>  * If there is no audio hw/driver there is no failure.
> 
> v3:
>  * Comment.
>  * Skip non-symlinks.
>  * Free path on failure and restore.
>  * Simplify with asprintf. (Chris Wilson)
> 
> v4:
>  * Find snd_hda_intel instance tied with an Intel device.
> 
> v5:
>  * Fix memory leak and silence Valgrind warning.
> 
> v6:
>  * Fix error out logic.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

CI looks promising, as far my knowledge goes (and I am sorry to say
finding the child devices is beyond my sysfs ken), series is
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux