== Series Details == Series: drm/i915: Interactive RPS mode URL : https://patchwork.freedesktop.org/series/46334/ State : warning == Summary == $ dim checkpatch origin/drm-tip f46e1cca8c23 drm/i915: Interactive RPS mode -:24: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e9af4ea2b9e7 ("drm/i915: Avoid waitboosting on the active request")' #24: full throttle and upclock the GPU to max. But in commit e9af4ea2b9e7, we -:69: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #69: FILE: drivers/gpu/drm/i915/i915_drv.h:788: + struct mutex power_lock; -:77: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #77: FILE: drivers/gpu/drm/i915/i915_drv.h:3434: +extern void intel_rps_set_power(struct drm_i915_private *dev_priv, total: 1 errors, 0 warnings, 2 checks, 185 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx