✗ Fi.CI.CHECKPATCH: warning for drm/i915: Hotplug cleanups and whanot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: Hotplug cleanups and whanot
URL   : https://patchwork.freedesktop.org/series/46022/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1684bcc70562 drm/i915: Introduce for_each_intel_dp()
-:21: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#21: FILE: drivers/gpu/drm/i915/intel_display.h:292:
+#define for_each_intel_dp(dev, intel_encoder)			\
+	for_each_intel_encoder(dev, intel_encoder)		\
+		for_each_if(intel_encoder_is_dp(intel_encoder))

-:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' - possible side-effects?
#21: FILE: drivers/gpu/drm/i915/intel_display.h:292:
+#define for_each_intel_dp(dev, intel_encoder)			\
+	for_each_intel_encoder(dev, intel_encoder)		\
+		for_each_if(intel_encoder_is_dp(intel_encoder))

total: 1 errors, 0 warnings, 1 checks, 86 lines checked
256e2e4aa625 drm/i915: Introduce intel_encoder_is_dig_port()
da7ac2ea4459 drm/i915: Rewrite mst suspend/resume in terms of encoders
bcef9f3f9672 drm/i915: Nuke dev_priv->irq_port[]
-:77: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "hpd_pulse"
#77: FILE: drivers/gpu/drm/i915/intel_hotplug.c:307:
+		enc_to_dig_port(&encoder->base)->hpd_pulse != NULL;

total: 0 errors, 0 warnings, 1 checks, 134 lines checked
74b17618be88 drm/i915: s/int i/enum hpd_pin pin/
7b7a0da658e7 drm/i915: Pass hpd_pin to long_pulse_detect()
d311117aa530 drm/i915: Assert that our hpd pin bitmasks don't overflow
f5d991118578 drm/i915: Print the long_mask alongside the pin_mask

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux