Re: [PATCH 7/8] drm/i915: Assert that our hpd pin bitmasks don't overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Ville Syrjala (2018-07-05 17:43:56)
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> Make sure our hpd pin count doesn't exceed the bitmasks we use
> for tracking pending hotplugs. Not ever close to the limit yet,
> but no harm in making sure either.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index bb7c754979f8..c107e0837026 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1713,6 +1713,8 @@ static void intel_get_hpd_pins(struct drm_i915_private *dev_priv,
>  {
>         enum hpd_pin pin;
>  
> +       BUILD_BUG_ON(HPD_NUM_PINS > 32);

sizeof(*pin_mask) * CHAR_BIT ?

Just looking for some explanation as where the limit comes from. Now
obviously u32, but why was u32 chosen?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux