== Series Details == Series: drm: Third attempt at fixing the fb-helper .best_encoder() mess (rev2) URL : https://patchwork.freedesktop.org/series/45580/ State : warning == Summary == $ dim checkpatch origin/drm-tip 27feace2e181 drm/fb-helper: Eliminate the .best_encoder() usage bd08e651f318 drm/i915: Nuke intel_mst_best_encoder() c31cba14dcaa drm: Add drm_connector_for_each_possible_encoder() -:139: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'connector' - possible side-effects? #139: FILE: include/drm/drm_connector.h:1202: +#define drm_connector_for_each_possible_encoder(connector, encoder, __i) \ + for ((__i) = 0; (__i) < ARRAY_SIZE((connector)->encoder_ids) && \ + (connector)->encoder_ids[(__i)] != 0; (__i)++) \ + for_each_if((encoder) = \ + drm_encoder_find((connector)->dev, NULL, \ + (connector)->encoder_ids[(__i)])) \ + -:139: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #139: FILE: include/drm/drm_connector.h:1202: +#define drm_connector_for_each_possible_encoder(connector, encoder, __i) \ + for ((__i) = 0; (__i) < ARRAY_SIZE((connector)->encoder_ids) && \ + (connector)->encoder_ids[(__i)] != 0; (__i)++) \ + for_each_if((encoder) = \ + drm_encoder_find((connector)->dev, NULL, \ + (connector)->encoder_ids[(__i)])) \ + total: 0 errors, 0 warnings, 2 checks, 99 lines checked 9ac85a361c63 drm/amdgpu: Use drm_connector_for_each_possible_encoder() 8807427952c1 drm/nouveau: Use drm_connector_for_each_possible_encoder() a84c10f13c19 drm/radeon: Use drm_connector_for_each_possible_encoder() f2e15e4ea45b drm: Add drm_connector_has_possible_encoder() -:23: WARNING:LONG_LINE_COMMENT: line over 100 characters #23: FILE: drivers/gpu/drm/drm_connector.c:335: + * drm_connector_has_possible_encoder - check if the connector and encoder are assosicated with each other total: 0 errors, 1 warnings, 0 checks, 38 lines checked 51b4ba4680b6 drm/msm: Use drm_connector_has_possible_encoder() 1a05980f45a6 drm/tilcdc: Use drm_connector_has_possible_encoder() _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx