== Series Details == Series: series starting with [01/37] drm/i915/gtt: Add read only pages to gen8_pte_encode URL : https://patchwork.freedesktop.org/series/45638/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5796c40dcb3f drm/i915/gtt: Add read only pages to gen8_pte_encode f2ea02d9cb6a drm/i915/gtt: Read-only pages for insert_entries on bdw+ -:192: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #192: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:330: + bool pt_kmap_wc:1; -:195: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #195: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:333: + bool has_read_only:1; -:271: WARNING:LINE_SPACING: Missing a blank line after declarations #271: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:430: + struct drm_file *file; + I915_RND_STATE(prng); -:342: ERROR:CODE_INDENT: code indent should use tabs where possible #342: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:501: +^I ^Indwords, INTEL_INFO(i915)->num_rings);$ -:342: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #342: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:501: +^I ^Indwords, INTEL_INFO(i915)->num_rings);$ -:342: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #342: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:501: + pr_info("Submitted %lu dwords (across %u engines)\n", + ndwords, INTEL_INFO(i915)->num_rings); total: 1 errors, 4 warnings, 1 checks, 323 lines checked 5db2b0804f50 drm/i915: Prevent writing into a read-only object via a GGTT mmap -:182: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32> #182: FILE: include/drm/drm_vma_manager.h:44: + bool readonly:1; total: 0 errors, 1 warnings, 0 checks, 118 lines checked 62c8b0d792a9 drm/i915: Reject attempted pwrites into a read-only object 8f1d71adde12 drm/i915/userptr: Enable read-only support on gen8+ b99af734e66a drm/i915: Move rate-limiting request retire to after submission f38ce0a80f57 drm/i915: Move engine request retirement to intel_engine_cs d7836ba1aadb drm/i915: Hold request reference for submission until retirement 380077f476a6 drm/i915/execlists: Switch to rb_root_cached 58dbf76c0881 drm/i915: Reserve some priority bits for internal use 7fa34185ea56 drm/i915: Combine multiple internal plists into the same i915_priolist bucket -:163: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #163: FILE: drivers/gpu/drm/i915/intel_lrc.c:367: + struct list_head *uninitialized_var(pl); -:280: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #280: FILE: drivers/gpu/drm/i915/intel_lrc.c:1241: + struct list_head *uninitialized_var(pl); -:309: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #309: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:197: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:309: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #309: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:197: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:201: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) -:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:201: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) total: 0 errors, 2 warnings, 4 checks, 271 lines checked 0d897534417f drm/i915: Priority boost for new clients 7d685300feb5 drm/i915: Priority boost switching to an idle ring 96ca772cff30 drm/i915: Refactor export_fence() after i915_vma_move_to_active() 0513e74c8106 drm/i915: Export i915_request_skip() b4b1dfde2a88 drm/i915: Start returning an error from i915_vma_move_to_active() 5d01124e29ba drm/i915: Track vma activity per fence.context, not per engine -:340: WARNING:LONG_LINE: line over 100 characters #340: FILE: drivers/gpu/drm/i915/i915_vma.c:919: + &vma->vm->i915->drm.struct_mutex)->fence.context); total: 0 errors, 1 warnings, 0 checks, 459 lines checked b4b4f8a2fa27 drm/i915: Track the last-active inside the i915_vma e697b7236be0 drm/i915: Stop tracking MRU activity on VMA d6f1f6ddd451 drm/i915: Introduce the i915_user_extension_method -:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 -:35: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #35: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1: +/* -:77: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #77: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1: +/* -:111: WARNING:TYPO_SPELLING: 'compatibilty' may be misspelled - perhaps 'compatibility'? #111: FILE: include/uapi/drm/i915_drm.h:71: + * and backward compatibilty, is to use a list of optional structs to total: 0 errors, 4 warnings, 0 checks, 89 lines checked 4b94cd137935 drm/i915: Extend CREATE_CONTEXT to allow inheritance ala clone() -:346: WARNING:LINE_SPACING: Missing a blank line after declarations #346: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:350: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:423: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #423: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:414: + ncontexts = dw = 0; -:494: CHECK:LINE_SPACING: Please don't use multiple blank lines #494: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:480: + -:538: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #538: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:529: + ncontexts = dw = 0; -:647: WARNING:LONG_LINE: line over 100 characters #647: FILE: include/uapi/drm/i915_drm.h:389: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_v2) -:647: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #647: FILE: include/uapi/drm/i915_drm.h:389: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_v2) -:647: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #647: FILE: include/uapi/drm/i915_drm.h:389: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_v2) total: 1 errors, 3 warnings, 3 checks, 564 lines checked cef03f724ae0 drm/i915: Allow contexts to share a single timeline across all engines 9fe542707065 drm/i915: Fix I915_EXEC_RING_MASK 081d094df2ec drm/i915: Re-arrange execbuf so context is known before engine ed799210e4e7 drm/i915: Allow a context to define its set of engines 24a5c97f2953 drm/i915/execlists: Flush the tasklet before unpinning -:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14: References: 60367132a214 ("drm/i915: Avoid use-after-free of ctx in request tracepoints") -:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 60367132a214 ("drm/i915: Avoid use-after-free of ctx in request tracepoints")' #14: References: 60367132a214 ("drm/i915: Avoid use-after-free of ctx in request tracepoints") total: 1 errors, 1 warnings, 0 checks, 57 lines checked 970e15cf47ab drm/i915/execlists: Refactor out can_merge_rq() 35a3cf4e41b2 drm/i915: Replace nested subclassing with explicit subclasses f84782d6c6ab RFC drm/i915: Load balancing across a virtual engine 8bf1f56ba199 drm/i915: Introduce i915_address_space.mutex 624594037120 drm/i915: Move fence register tracking to GGTT fa045278d4b4 drm/i915: Convert fences to use a GGTT lock rather than struct_mutex 3facb74c4b93 drm/i915: Tidy i915_gem_suspend() 1a5428a95445 drm/i915: Move fence-reg interface to i915_gem_fence_reg.h 1a21e8394583 drm/i915: Dynamically allocate the array of drm_i915_gem_fence_reg cc06844dd041 drm/i915: Pull all the reset functionality together into i915_reset.c -:1070: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #1070: new file mode 100644 -:1075: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1075: FILE: drivers/gpu/drm/i915/i915_reset.c:1: +/* -:1216: WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'? #1216: FILE: drivers/gpu/drm/i915/i915_reset.c:142: + /* Assert reset for at least 20 usec, and wait for acknowledgement. */ -:1394: CHECK:LINE_SPACING: Please don't use multiple blank lines #1394: FILE: drivers/gpu/drm/i915/i915_reset.c:320: + + -:1794: WARNING:MEMORY_BARRIER: memory barrier without comment #1794: FILE: drivers/gpu/drm/i915/i915_reset.c:720: + smp_mb__after_atomic(); -:2162: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects? #2162: FILE: drivers/gpu/drm/i915/i915_reset.c:1088: +#define i915_wedge_on_timeout(W, DEV, TIMEOUT) \ + for (__init_wedge((W), (DEV), (TIMEOUT), __func__); \ + (W)->i915; \ + __fini_wedge((W))) -:2173: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #2173: FILE: drivers/gpu/drm/i915/i915_reset.c:1099: + char *error_event[] = { I915_ERROR_UEVENT "=1", NULL }; -:2174: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #2174: FILE: drivers/gpu/drm/i915/i915_reset.c:1100: + char *reset_event[] = { I915_RESET_UEVENT "=1", NULL }; -:2175: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const #2175: FILE: drivers/gpu/drm/i915/i915_reset.c:1101: + char *reset_done_event[] = { I915_ERROR_UEVENT "=0", NULL }; -:2353: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #2353: FILE: drivers/gpu/drm/i915/i915_reset.h:1: +/* total: 0 errors, 8 warnings, 2 checks, 2807 lines checked 18b6327d9393 drm/i915: Remove GPU reset dependence on struct_mutex -:610: WARNING:MEMORY_BARRIER: memory barrier without comment #610: FILE: drivers/gpu/drm/i915/i915_reset.c:564: + smp_store_mb(i915->gpu_error.restart, NULL); total: 0 errors, 1 warnings, 0 checks, 1238 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
