On Thu, Jun 28, 2018 at 11:36:00AM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-06-28 at 08:48 +0200, Daniel Vetter wrote: > > On Wed, Jun 27, 2018 at 11:18:54PM -0700, Dhinakaran Pandiyan wrote: > > > > > > There is already a check to allow only RGB8888 formats with CCS > > > modifiers. > > > > > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > > Thanks for the reviews. > > > > Aside: intel_framebuffer_init is horribly long function, and it would > > probably make a lot of sense to extract all the framebuffer related > > stuff > > into a new intel_framebuffer.c file. intel_display.c is a bit ... big > > :-) > > Yup, it's become a pain to add new stuff. I'll add this to my todo > list. A big chunk of intel_framebuffer_init() should simply be disappeared. I tried but couldn't really come up with any entirely satisfactory solution. Someone should revisit that topic now that we at least figured out what to do with the .format_mod_supported() vs. plane->modifiers[]. https://patchwork.freedesktop.org/series/39384/ https://patchwork.freedesktop.org/series/39701/ https://patchwork.freedesktop.org/series/39814/ -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
