On Thu, 6 Dec 2012 11:12:40 -0200, Paulo Zanoni <przanoni at gmail.com> wrote: > From: Paulo Zanoni <paulo.r.zanoni at intel.com> > > A big part of the Haswell display code is called intel_ddi_something > while a small part of it is called haswell_something. Being consistent > with the naming standards is a nice thing, so IMHO we should only use > one of the naming standards for everything. > > So instead of converting everything to haswell_something I converted > to ddi_something, which seems more appropriate IMHO. Now our code > looks a little bit more consistent. > > The next step is to move everything to intel_ddi.c. Nak. Now you are really muddying the waters between generation specific paths and one implementation of a display engine. A few chunks are good; where you are indeed checking for the digital ports, but most look silly. -Chris -- Chris Wilson, Intel Open Source Technology Centre
