Re: 4.18-rc1 i915 dma mapping warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Joonas Lahtinen (2018-06-19 14:16:08)
> + Chris,
> 
> Somehow this message managed to dodge the mailing list?
> 
> Regards, Joonas
> 
> Quoting Dave Jones (2018-06-19 05:52:23)
> > The new DMA mapping debug option in 4.18-rc1 (CONFIG_DMA_API_DEBUG_SG) seems to dislike something about i915..

See

commit 002edb6f6f2a79bea50de11260ddc9572e6db731
Author: Robin Murphy <robin.murphy@xxxxxxx>
Date:   Fri Nov 6 16:32:51 2015 -0800

    dma-mapping: tidy up dma_parms default handling
    
    Many DMA controllers and other devices set max_segment_size to
    indicate their scatter-gather capability, but have no interest in
    segment_boundary_mask. However, the existence of a dma_parms structure
    precludes the use of any default value, leaving them as zeros (assuming
    a properly kzalloc'ed structure). If a well-behaved IOMMU (or SWIOTLB)
    then tries to respect this by ensuring a mapped segment does not cross
    a zero-byte boundary, hilarity ensues.
    
    Since zero is a nonsensical value for either parameter, treat it as an
    indicator for "default", as might be expected. In the process, clean up
    a bit by replacing the bare constants with slightly more meaningful
    macros and removing the superfluous "else" statements.
    
    [akpm@xxxxxxxxxxxxxxxxxxxx: dma-mapping.h needs sizes.h for SZ_64K]
    Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
    Reviewed-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
    Acked-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
    Cc: Arnd Bergmann <arnd@xxxxxxxx>
    Cc: Sakari Ailus <sakari.ailus@xxxxxx>
    Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

for no explanation whatever for the magical value.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux