Quoting Joonas Lahtinen (2018-06-18 12:01:16) > Quoting Chris Wilson (2018-06-18 12:41:50) > > Having the w/a registers as an open-coded table leaves a trap for the > > unwary; it would be easy to miss incrementing the LRI counter when > > adding a new register to the list. Instead, pull the list of registers > > into a table, so that we only need add new registers to that table > > rather than try and remember important side-effects of earlier chunks of > > GPU instructions. > > > > Suggested-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Not related to this patch, but the lack of OOB check for batch makes > one itch a little bit. We check for the overflow afterwards, if we get that far before the machine dies. As it's static, that seems reasonable as we'll cover it entirely in CI. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
