On Fri, Jun 15, 2018 at 02:10:56PM +0000, Michal Wajdeczko wrote:
> While debugging we may want to examine params passed to GuC.
> Print them all if config I915_DEBUG_GUC is enabled.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> Cc: Michel Thierry <michel.thierry@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_guc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> index 1aff30b..f84fbde 100644
> --- a/drivers/gpu/drm/i915/intel_guc.c
> +++ b/drivers/gpu/drm/i915/intel_guc.c
> @@ -327,6 +327,11 @@ void intel_guc_init_params(struct intel_guc *guc)
> params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
> params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
>
> +#ifdef CONFIG_DRM_I915_DEBUG_GUC
> + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
> + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
> +#endif
> +
It's not even called if we're not using GuC, please drop the ifdef.
We don't want to sprinkle #ifdefs for GuC debug all over the place, and if we do
care about differentiation between GuC related stuff, we should probably create
a separate printer (like for GuC CT).
-Michał
> /*
> * All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and
> * they are power context saved so it's ok to release forcewake
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
