== Series Details == Series: series starting with [01/21] drm/i915/execlists: Pull submit after dequeue under timeline lock URL : https://patchwork.freedesktop.org/series/44860/ State : warning == Summary == $ dim checkpatch origin/drm-tip cf612f0dd64d drm/i915/execlists: Pull submit after dequeue under timeline lock 0668ace61a3e drm/i915/execlists: Pull CSB reset under the timeline.lock d31281c9506a drm/i915/execlists: Process one CSB update at a time -:35: WARNING:MEMORY_BARRIER: memory barrier without comment #35: FILE: drivers/gpu/drm/i915/intel_lrc.c:972: + smp_mb__after_atomic(); -:77: WARNING:LONG_LINE: line over 100 characters #77: FILE: drivers/gpu/drm/i915/intel_lrc.c:996: + head, GEN8_CSB_READ_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?", -:78: WARNING:LONG_LINE: line over 100 characters #78: FILE: drivers/gpu/drm/i915/intel_lrc.c:997: + tail, GEN8_CSB_WRITE_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?"); -:140: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #140: FILE: drivers/gpu/drm/i915/intel_lrc.c:1028: + status, buf[2*head + 1], ^ -:176: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #176: FILE: drivers/gpu/drm/i915/intel_lrc.c:1046: + buf[2*head + 1] == execlists->preempt_complete_status) { ^ total: 0 errors, 3 warnings, 2 checks, 301 lines checked 0396520798dd drm/i915/execlists: Unify CSB access pointers cbf8024c8d7c drm/i915/execlists: Direct submission of new requests (avoid tasklet/ksoftirqd) -:102: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #102: References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half") -:102: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")' #102: References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half") total: 1 errors, 1 warnings, 0 checks, 358 lines checked 19ec2ad8622d drm/i915: Move rate-limiting request retire to after submission b56b11ad1d41 drm/i915: Wait for engines to idle before retiring dcdb95a15db3 drm/i915: Move engine request retirement to intel_engine_cs eb745a6ba634 drm/i915: Hold request reference for submission until retirement ee4a4f30c645 drm/i915: Reduce spinlock hold time during notify_ring() interrupt 4aa816620f05 drm/i915: Move the irq_counter inside the spinlock af882fd09e95 drm/i915: Only signal from interrupt when requested da1f2b3ab91d drm/i915/execlists: Switch to rb_root_cached afa0c32cc987 drm/i915: Reserve some priority bits for internal use 3a1e18628371 drm/i915: Combine multiple internal plists into the same i915_priolist bucket -:163: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #163: FILE: drivers/gpu/drm/i915/intel_lrc.c:367: + struct list_head *uninitialized_var(pl); -:280: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name #280: FILE: drivers/gpu/drm/i915/intel_lrc.c:1222: + struct list_head *uninitialized_var(pl); -:309: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #309: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:197: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:309: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #309: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:197: +#define priolist_for_each_request(it, plist, idx) \ + for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \ + list_for_each_entry(it, &(plist)->requests[idx], sched.link) -:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects? #313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:201: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) -:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:201: +#define priolist_for_each_request_consume(it, n, plist, idx) \ + for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \ + list_for_each_entry_safe(it, n, \ + &(plist)->requests[idx - 1], \ + sched.link) total: 0 errors, 2 warnings, 4 checks, 271 lines checked 3e54c9623a6d drm/i915: Priority boost for new clients 9ae4712e31dd drm/i915: Priority boost switching to an idle ring 29befc946621 drm/i915: Refactor export_fence() after i915_vma_move_to_active() 3294e94ccd3b drm/i915: Start returning an error from i915_vma_move_to_active() 42b4fe871705 drm/i915: Track vma activity per fence.context, not per engine -:340: WARNING:LONG_LINE: line over 100 characters #340: FILE: drivers/gpu/drm/i915/i915_vma.c:886: + &vma->vm->i915->drm.struct_mutex)->fence.context); total: 0 errors, 1 warnings, 0 checks, 459 lines checked 382b189f4b52 drm/i915: Track the last-active inside the i915_vma _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
