Re: [PATCH 06/11] drm/i915/gtt: Subclass gen6_hw_ppgtt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Chris Wilson (2018-06-05 10:19:44)
> The legacy gen6 ppgtt needs a little more hand holding than gen8+, and
> so requires a larger structure. As I intend to make this slightly more
> complicated in the future, separate the gen6 from the core gen8 hw
> struct by subclassing. This patch moves the gen6 only features out to
> gen6_hw_ppgtt and pipes the new type everywhere that needs it.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> Cc: Matthew Auld <matthew.william.auld@xxxxxxxxx>

It's at times confusing when gen6_foo takes either the ppgtt or
ppgtt->base, but at least compiler will protect from that.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux