Re: [PATCH i-g-t 1/3] lib: Assert that we do manage to submit at least one batch when measuring

Antonio Argenziano <antonio.argenziano@xxxxxxxxx> · Wed, 30 May 2018 09:27:05 -0700

On 30/05/18 03:33, Chris Wilson wrote:
As we measure the ring size, we never expect to find we can not submit
no batches at all. Assert against the unexpected.

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Antonio Argenziano <antonio.argenziano@xxxxxxxxx>
---
  lib/i915/gem_ring.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/lib/i915/gem_ring.c b/lib/i915/gem_ring.c
index 10d2f2cd4..7d64165eb 100644
--- a/lib/i915/gem_ring.c
+++ b/lib/i915/gem_ring.c
@@ -100,6 +100,7 @@ __gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags
  	} while (1);
  
  	igt_assert_eq(__execbuf(fd, &execbuf), -EINTR);
+	igt_assert(count);

Maybe a courtesy print?

With or without,
Reviewed-by: Antonio Argenziano <antonio.argenziano@xxxxxxxxx>

  
  	memset(&itv, 0, sizeof(itv));
  	setitimer(ITIMER_REAL, &itv, NULL);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx







