== Series Details == Series: series starting with [1/7] drm/i915/guc: Don't store runtime GuC log level in modparam URL : https://patchwork.freedesktop.org/series/43952/ State : warning == Summary == $ dim checkpatch origin/drm-tip ef254da06d89 drm/i915/guc: Don't store runtime GuC log level in modparam fa025916c333 drm/i915/guc: Refactoring preparation of the GUC_CTL_DEBUG parameter 492303e41449 drm/i915/guc: Refactoring preparation of the GUC_CTL_FEATURE parameter dcdde612e96a drm/i915/guc: Refactoring preparation of the GUC_CTL_LOG_PARAMS parameter -:30: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #30: FILE: drivers/gpu/drm/i915/intel_guc.c:242: } +static u32 guc_ctl_log_params_flags(struct intel_guc *guc) total: 0 errors, 0 warnings, 1 checks, 60 lines checked 6848b97dc926 drm/i915/guc: Refactoring preparation of the GUC_CTL_CTXINFO parameter -:35: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #35: FILE: drivers/gpu/drm/i915/intel_guc.c:250: + if (USES_GUC_SUBMISSION(guc_to_i915(guc))) { + total: 0 errors, 0 warnings, 1 checks, 42 lines checked f72db2efed06 drm/i915/guc: Move defines with size of GuC logs to intel_guc_log.h -:42: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #42: FILE: drivers/gpu/drm/i915/intel_guc.c:275: + BUILD_BUG_ON((CRASH_BUFFER_SIZE/UNIT - 1) > ^ -:44: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #44: FILE: drivers/gpu/drm/i915/intel_guc.c:277: + BUILD_BUG_ON((DPC_BUFFER_SIZE/UNIT - 1) > ^ -:46: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #46: FILE: drivers/gpu/drm/i915/intel_guc.c:279: + BUILD_BUG_ON((ISR_BUFFER_SIZE/UNIT - 1) > ^ -:51: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #51: FILE: drivers/gpu/drm/i915/intel_guc.c:284: + ((CRASH_BUFFER_SIZE/UNIT - 1) << GUC_LOG_CRASH_SHIFT) | ^ -:52: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #52: FILE: drivers/gpu/drm/i915/intel_guc.c:285: + ((DPC_BUFFER_SIZE/UNIT - 1) << GUC_LOG_DPC_SHIFT) | ^ -:53: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #53: FILE: drivers/gpu/drm/i915/intel_guc.c:286: + ((ISR_BUFFER_SIZE/UNIT - 1) << GUC_LOG_ISR_SHIFT) | ^ total: 0 errors, 0 warnings, 6 checks, 128 lines checked 0ad99c4dbd3b drm/i915/guc: Add support for define guc_log_size in megabytes. -:47: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #47: FILE: drivers/gpu/drm/i915/intel_guc.c:291: + flags |= ((CRASH_BUFFER_SIZE/UNIT - 1) << GUC_LOG_CRASH_SHIFT) | ^ total: 0 errors, 0 warnings, 1 checks, 45 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
