On Thu, 2018-05-24 at 20:55 +0000, Patchwork wrote: > == Series Details == > > Series: gpu: Consistently use octal not symbolic permissions > URL : https://patchwork.freedesktop.org/series/43729/ > State : warning All of these are existing and expected. Is there something else required? > == Summary == > > $ dim checkpatch origin/drm-tip > ce883dbd4f90 gpu: Consistently use octal not symbolic permissions > -:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #18: > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...> > > -:53: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_dpm_forced_performance_level' to 'power_dpm_force_performance_level_show' 'amdgpu_set_dpm_forced_performance_level' to 'power_dpm_force_performance_level_store' > #53: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:909: > +static DEVICE_ATTR(power_dpm_force_performance_level, 0644, > > -:85: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_num_states' to 'pp_num_states_show' > #85: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:912: > +static DEVICE_ATTR(pp_num_states, 0444, amdgpu_get_pp_num_states, NULL); > > -:86: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_cur_state' to 'pp_cur_state_show' > #86: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:913: > +static DEVICE_ATTR(pp_cur_state, 0444, amdgpu_get_pp_cur_state, NULL); > > -:87: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_force_state' to 'pp_force_state_show' 'amdgpu_set_pp_force_state' to 'pp_force_state_store' > #87: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:914: > +static DEVICE_ATTR(pp_force_state, 0644, > > -:90: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_table' to 'pp_table_show' 'amdgpu_set_pp_table' to 'pp_table_store' > #90: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:917: > +static DEVICE_ATTR(pp_table, 0644, > > -:93: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_dpm_sclk' to 'pp_dpm_sclk_show' 'amdgpu_set_pp_dpm_sclk' to 'pp_dpm_sclk_store' > #93: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:920: > +static DEVICE_ATTR(pp_dpm_sclk, 0644, > > -:96: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_dpm_mclk' to 'pp_dpm_mclk_show' 'amdgpu_set_pp_dpm_mclk' to 'pp_dpm_mclk_store' > #96: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:923: > +static DEVICE_ATTR(pp_dpm_mclk, 0644, > > -:99: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_dpm_pcie' to 'pp_dpm_pcie_show' 'amdgpu_set_pp_dpm_pcie' to 'pp_dpm_pcie_store' > #99: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:926: > +static DEVICE_ATTR(pp_dpm_pcie, 0644, > > -:102: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_sclk_od' to 'pp_sclk_od_show' 'amdgpu_set_pp_sclk_od' to 'pp_sclk_od_store' > #102: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:929: > +static DEVICE_ATTR(pp_sclk_od, 0644, > > -:105: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_mclk_od' to 'pp_mclk_od_show' 'amdgpu_set_pp_mclk_od' to 'pp_mclk_od_store' > #105: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:932: > +static DEVICE_ATTR(pp_mclk_od, 0644, > > -:108: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_power_profile_mode' to 'pp_power_profile_mode_show' 'amdgpu_set_pp_power_profile_mode' to 'pp_power_profile_mode_store' > #108: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:935: > +static DEVICE_ATTR(pp_power_profile_mode, 0644, > > -:111: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'amdgpu_get_pp_od_clk_voltage' to 'pp_od_clk_voltage_show' 'amdgpu_set_pp_od_clk_voltage' to 'pp_od_clk_voltage_store' > #111: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:938: > +static DEVICE_ATTR(pp_od_clk_voltage, 0644, > > -:141: WARNING:LONG_LINE: line over 100 characters > #141: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:1327: > +static SENSOR_DEVICE_ATTR(pwm1_enable, 0644, amdgpu_hwmon_get_pwm1_enable, amdgpu_hwmon_set_pwm1_enable, 0); > > -:152: WARNING:LONG_LINE: line over 100 characters > #152: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:1338: > +static SENSOR_DEVICE_ATTR(power1_cap, 0644, amdgpu_hwmon_show_power_cap, amdgpu_hwmon_set_power_cap, 0); > > -:362: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'show_rc6_ms' to 'rc6_residency_ms_show' > #362: FILE: drivers/gpu/drm/i915/i915_sysfs.c:104: > +static DEVICE_ATTR(rc6_residency_ms, 0444, show_rc6_ms, NULL); > > -:363: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'show_rc6p_ms' to 'rc6p_residency_ms_show' > #363: FILE: drivers/gpu/drm/i915/i915_sysfs.c:105: > +static DEVICE_ATTR(rc6p_residency_ms, 0444, show_rc6p_ms, NULL); > > -:364: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'show_rc6pp_ms' to 'rc6pp_residency_ms_show' > #364: FILE: drivers/gpu/drm/i915/i915_sysfs.c:106: > +static DEVICE_ATTR(rc6pp_residency_ms, 0444, show_rc6pp_ms, NULL); > > -:365: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'show_media_rc6_ms' to 'media_rc6_residency_ms_show' > #365: FILE: drivers/gpu/drm/i915/i915_sysfs.c:107: > +static DEVICE_ATTR(media_rc6_residency_ms, 0444, show_media_rc6_ms, NULL); > > -:394: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP0_freq_mhz_show' > #394: FILE: drivers/gpu/drm/i915/i915_sysfs.c:463: > +static DEVICE_ATTR(gt_RP0_freq_mhz, 0444, gt_rp_mhz_show, NULL); > > -:395: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP1_freq_mhz_show' > #395: FILE: drivers/gpu/drm/i915/i915_sysfs.c:464: > +static DEVICE_ATTR(gt_RP1_freq_mhz, 0444, gt_rp_mhz_show, NULL); > > -:396: CHECK:CAMELCASE: Avoid CamelCase: <gt_RPn_freq_mhz> > #396: FILE: drivers/gpu/drm/i915/i915_sysfs.c:465: > +static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL); > > -:396: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RPn_freq_mhz_show' > #396: FILE: drivers/gpu/drm/i915/i915_sysfs.c:465: > +static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL); > > -:433: WARNING:EXPORTED_WORLD_WRITABLE: Exporting world writable files is usually an error. Consider more restrictive permissions. > #433: FILE: drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:180: > + ent = debugfs_create_file("reset", 0222, minor->debugfs_root, > > -:496: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'dsicm_hw_revision_show' to 'hw_revision_show' > #496: FILE: drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:573: > +static DEVICE_ATTR(hw_revision, 0444, dsicm_hw_revision_show, NULL); > > -:497: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'dsicm_show_ulps' to 'ulps_show' 'dsicm_store_ulps' to 'ulps_store' > #497: FILE: drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:574: > +static DEVICE_ATTR(ulps, 0644, dsicm_show_ulps, dsicm_store_ulps); > > -:498: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'dsicm_show_ulps_timeout' to 'ulps_timeout_show' 'dsicm_store_ulps_timeout' to 'ulps_timeout_store' > #498: FILE: drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:575: > +static DEVICE_ATTR(ulps_timeout, 0644, > > -:516: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'show_cabc_available_modes' to 'cabc_available_modes_show' > #516: FILE: drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c:496: > +static DEVICE_ATTR(cabc_available_modes, 0444, show_cabc_available_modes, NULL); > > -:536: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'tpo_td043_mode_show' to 'mode_show' 'tpo_td043_mode_store' to 'mode_store' > #536: FILE: drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c:273: > +static DEVICE_ATTR(mode, 0644, tpo_td043_mode_show, tpo_td043_mode_store); > > -:537: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'tpo_td043_gamma_show' to 'gamma_show' 'tpo_td043_gamma_store' to 'gamma_store' > #537: FILE: drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c:274: > +static DEVICE_ATTR(gamma, 0644, tpo_td043_gamma_show, tpo_td043_gamma_store); > > -:554: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'radeon_get_pm_method' to 'power_method_show' 'radeon_set_pm_method' to 'power_method_store' > #554: FILE: drivers/gpu/drm/radeon/radeon_pm.c:659: > +static DEVICE_ATTR(power_method, 0644, radeon_get_pm_method, radeon_set_pm_method); > > -:555: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'radeon_get_dpm_state' to 'power_dpm_state_show' 'radeon_set_dpm_state' to 'power_dpm_state_store' > #555: FILE: drivers/gpu/drm/radeon/radeon_pm.c:660: > +static DEVICE_ATTR(power_dpm_state, 0644, radeon_get_dpm_state, radeon_set_dpm_state); > > -:556: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'radeon_get_dpm_forced_performance_level' to 'power_dpm_force_performance_level_show' 'radeon_set_dpm_forced_performance_level' to 'power_dpm_force_performance_level_store' > #556: FILE: drivers/gpu/drm/radeon/radeon_pm.c:661: > +static DEVICE_ATTR(power_dpm_force_performance_level, 0644, > > -:575: WARNING:LONG_LINE: line over 100 characters > #575: FILE: drivers/gpu/drm/radeon/radeon_pm.c:706: > +static SENSOR_DEVICE_ATTR(pwm1_enable, 0644, radeon_hwmon_get_pwm1_enable, radeon_hwmon_set_pwm1_enable, 0); > > total: 0 errors, 33 warnings, 1 checks, 603 lines checked > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
