On 24/05/2018 16:29, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-05-24 16:04:46)
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Instead of using the engine->id, use uabi_class:instance pairs in trace-
points including engine info.
Should we not pack dev,hw_id,class,instance into u16s?
Can do.
This will be more readable, more future proof and more stable for
userspace consumption.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: svetlana.kukanova@xxxxxxxxx
---
@@ -616,7 +621,8 @@ TRACE_EVENT(i915_request_queue,
TP_STRUCT__entry(
__field(u32, dev)
__field(u32, hw_id)
- __field(u32, ring)
+ __field(u32, class)
+ __field(u32, instance)
__field(u32, ctx)
ctx needs u64 :(
I've no objection to switching to our hopefully futureproof uabi
nomenclature.
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Thanks, I'll grow the series with all of the above.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
