On Wed, May 23, 2018 at 12:43:16PM +0300, Jani Nikula wrote: > On Fri, 18 May 2018, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > We don't support using the power sequencer with other ports besides LVDS > > on pre-ilk platforms. WARN if someone has mistakenly connected the power > > sequencer to the wrong port. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> Series pushed to dinq. Thanks for the review. > > > > --- > > drivers/gpu/drm/i915/intel_display.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index a7702a72cd69..4773a4f52bfe 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -1236,7 +1236,12 @@ void assert_panel_unlocked(struct drm_i915_private *dev_priv, enum pipe pipe) > > pp_reg = PP_CONTROL(pipe); > > panel_pipe = pipe; > > } else { > > + u32 port_sel; > > + > > pp_reg = PP_CONTROL(0); > > + port_sel = I915_READ(PP_ON_DELAYS(0)) & PANEL_PORT_SELECT_MASK; > > + > > + WARN_ON(port_sel != PANEL_PORT_SELECT_LVDS); > > intel_lvds_port_enabled(dev_priv, LVDS, &panel_pipe); > > } > > -- > Jani Nikula, Intel Open Source Graphics Center -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx