Re: [PATCH v5 7/7] drm/i915: Expose RPCS (SSEU) configuration to userspace

[Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>]

On 22/05/18 17:11, Lionel Landwerlin wrote:

On 21/05/18 17:00, Tvrtko Ursulin wrote:

+
+    /* Queue this switch after all other activity */
+    list_for_each_entry(timeline, &dev_priv->gt.timelines, link) {

This can iterate over gt.active_rings for a shorter walk. See current state of engine_has_idle_kernel_context.

For some reason, iterating over gt.active_rings will trigger an invalid memory access :|

Not sure what's wrong here...

Duh!

Found it :

list_for_each_entry(ring, &dev_priv->gt.active_rings, link) {

Instead of :

list_for_each_entry(ring, &dev_priv->gt.active_rings, active_link) {

-
Lionel

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx