Re: [PATCH] drm/i915/query: Protect tainted function pointer lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Lionel Landwerlin (2018-05-21 23:20:56)
> On 21/05/18 22:05, Chris Wilson wrote:
> > Smatch identifies i915_query_ioctl() as being a potential victim of
> > Spectre due to it use of a tainted user index into a function pointer
> > array. Use array_index_nospec() to defang the user index before using it
> > to lookup the function pointer.
> >
> > Fixes: a446ae2c6e65 ("drm/i915: add query uAPI")
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>
> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> Okay.
> 
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>

Indeed, it's all magic to me. Thanks for checking, I'll apply shortly.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux