Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> writes: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Up to now we've used the plane's modifier list as the primary > source of information for which modifiers are supported by a > given plane. In order to allow auxiliary metadata to be embedded > within the bits of the modifier we need to stop doing that. > > Thus we have to make .format_mod_supported() aware of the plane's > capabilities and gracefully deal with any modifier being passed > in directly from userspace. This seems like it would be a lot shorter if you just had a helper to check if your format and modifier was in drm_plane->format_types and drm_plane->modifiers, since then you wouldn't be duplicating your tables and you wouldn't need has_ccs either. However, it's not my driver and it unblocks vc4's patch, so: Reviewed-by: Eric Anholt <eric@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
