On Monday 21 May 2018 06:53 PM, Patchwork wrote:
== Series Details ==
Series: drm/i915: Implement HDCP2.2 (rev5)
URL : https://patchwork.freedesktop.org/series/38254/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm: hdcp2.2 authentication msg definitions
Okay!
Commit: drm: HDMI and DP specific HDCP2.2 defines
Okay!
Commit: mei: bus: whitelist hdcp client
Okay!
Commit: misc/mei/hdcp: Client driver for HDCP application
Okay!
Commit: misc/mei/hdcp: Notifier chain for mei cldev state change
Okay!
Commit: misc/mei/hdcp: Define ME FW interface for HDCP2.2
Okay!
Commit: linux/mei: Header for mei_hdcp driver interface
Okay!
Commit: misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
Okay!
Commit: misc/mei/hdcp: Verify Receiver Cert and prepare km
Okay!
Commit: misc/mei/hdcp: Verify H_prime
Okay!
Commit: misc/mei/hdcp: Store the HDCP Pairing info
Okay!
Commit: misc/mei/hdcp: Initiate Locality check
Okay!
Commit: misc/mei/hdcp: Verify L_prime
Okay!
Commit: misc/mei/hdcp: Prepare Session Key
Okay!
Commit: misc/mei/hdcp: Repeater topology verification and ack
Okay!
Commit: misc/mei/hdcp: Verify M_prime
Okay!
Commit: misc/mei/hdcp: Enabling the HDCP authentication
Okay!
Commit: misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
Okay!
Commit: drm/i915: wrapping all hdcp var into intel_hdcp
Okay!
Commit: drm/i915: Define HDCP2.2 related variables
Okay!
Commit: drm/i915: Define Intel HDCP2.2 registers
Okay!
Commit: drm/i915: Wrappers for mei HDCP2.2 services
+ ^~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~~
+cc1: all warnings being treated as errors
+drivers/gpu/drm/i915/intel_hdcp.c:1004:1: error: ‘hdcp2_verify_lprime’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1020:12: error: ‘hdcp2_prepare_skey’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1037:1: error: ‘hdcp2_verify_rep_topology_prepare_ack’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1057:1: error: ‘hdcp2_verify_mprime’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1074:12: error: ‘hdcp2_authenticate_port’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:904:1: error: ‘hdcp2_prepare_ake_init’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:934:1: error: ‘hdcp2_verify_rx_cert_prepare_km’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:954:12: error: ‘hdcp2_verify_hprime’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:971:1: error: ‘hdcp2_store_pairing_info’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:988:1: error: ‘hdcp2_prepare_lc_init’ defined but not used [-Werror=unused-function]
Jani and all,
To avoid these warning in bisecting, what is the preferred method in
intel-gfx?
1. Reverse the order of patches, as consumer functions first with
dummy service functions and then fill the dummy functions with proper
definitions?
2. Or combine all of them in single lengthy patches? HDCP1.4 was
done in that manner.
Please help with preferred approach.
Thanks,
Ram
+ hdcp2_prepare_ake_init(struct intel_hdcp *hdcp, struct hdcp2_ake_init *ake_data)
+ hdcp2_prepare_lc_init(struct intel_hdcp *hdcp, struct hdcp2_lc_init *lc_init)
+ hdcp2_store_pairing_info(struct intel_hdcp *hdcp,
+ hdcp2_verify_lprime(struct intel_hdcp *hdcp,
+ hdcp2_verify_mprime(struct intel_hdcp *hdcp,
+ hdcp2_verify_rep_topology_prepare_ack(
+ hdcp2_verify_rx_cert_prepare_km(struct intel_hdcp *hdcp,
+make[1]: *** [drivers/gpu/drm/i915] Error 2
+make[2]: *** [drivers/gpu/drm/i915/intel_hdcp.o] Error 1
+make: *** [drivers/gpu/drm/] Error 2
+ static int hdcp2_authenticate_port(struct intel_hdcp *hdcp)
+ static int hdcp2_prepare_skey(struct intel_hdcp *hdcp,
+ static int hdcp2_verify_hprime(struct intel_hdcp *hdcp,
Commit: drm/i915: Implement HDCP2.2 receiver authentication
- ^~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~
-drivers/gpu/drm/i915/intel_hdcp.c:1005:1: error: ‘hdcp2_verify_lprime’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:1021:12: error: ‘hdcp2_prepare_skey’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:1075:12: error: ‘hdcp2_authenticate_port’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:905:1: error: ‘hdcp2_prepare_ake_init’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:935:1: error: ‘hdcp2_verify_rx_cert_prepare_km’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:955:12: error: ‘hdcp2_verify_hprime’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:972:1: error: ‘hdcp2_store_pairing_info’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:989:1: error: ‘hdcp2_prepare_lc_init’ defined but not used [-Werror=unused-function]
- hdcp2_prepare_ake_init(struct intel_hdcp *hdcp, struct hdcp2_ake_init *ake_data)
- hdcp2_prepare_lc_init(struct intel_hdcp *hdcp, struct hdcp2_lc_init *lc_init)
- hdcp2_store_pairing_info(struct intel_hdcp *hdcp,
- hdcp2_verify_lprime(struct intel_hdcp *hdcp,
+drivers/gpu/drm/i915/intel_hdcp.c:1229:12: error: ‘hdcp2_authenticate_sink’ defined but not used [-Werror=unused-function]
- hdcp2_verify_rx_cert_prepare_km(struct intel_hdcp *hdcp,
- static int hdcp2_authenticate_port(struct intel_hdcp *hdcp)
- static int hdcp2_prepare_skey(struct intel_hdcp *hdcp,
- static int hdcp2_verify_hprime(struct intel_hdcp *hdcp,
+ static int hdcp2_authenticate_sink(struct intel_connector *connector)
Commit: drm/i915: Implement HDCP2.2 repeater authentication
- ^~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-drivers/gpu/drm/i915/intel_hdcp.c:1038:1: error: ‘hdcp2_verify_rep_topology_prepare_ack’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:1058:1: error: ‘hdcp2_verify_mprime’ defined but not used [-Werror=unused-function]
-O:drivers/gpu/drm/i915/intel_hdcp.c:1229:12: error: ‘hdcp2_authenticate_sink’ defined but not used [-Werror=unused-function]
- hdcp2_verify_mprime(struct intel_hdcp *hdcp,
- hdcp2_verify_rep_topology_prepare_ack(
+drivers/gpu/drm/i915/intel_hdcp.c:1247:30: expected restricted __be16 [assigned] [usertype] k
+drivers/gpu/drm/i915/intel_hdcp.c:1247:30: got int
+drivers/gpu/drm/i915/intel_hdcp.c:1247:30: warning: incorrect type in assignment (different base types)
+drivers/gpu/drm/i915/intel_hdcp.c:1343:12: error: ‘hdcp2_authenticate_sink’ defined but not used [-Werror=unused-function]
Commit: drm/i915: Enable and Disable HDCP2.2 port encryption
+ ^~~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~~~
+drivers/gpu/drm/i915/intel_hdcp.c:1402:12: error: ‘hdcp2_enable_encryption’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1432:12: error: ‘hdcp2_disable_encryption’ defined but not used [-Werror=unused-function]
+ static int hdcp2_disable_encryption(struct intel_connector *connector)
+ static int hdcp2_enable_encryption(struct intel_connector *connector)
Commit: drm/i915: Implement HDCP2.2 En/Dis-able
- ^~~~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~
-drivers/gpu/drm/i915/intel_hdcp.c:1347:12: error: ‘hdcp2_authenticate_sink’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:1405:12: error: ‘hdcp2_enable_encryption’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:1435:12: error: ‘hdcp2_disable_encryption’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1493:12: error: ‘_intel_hdcp2_disable’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1507:12: error: ‘_intel_hdcp2_enable’ defined but not used [-Werror=unused-function]
- static int hdcp2_authenticate_sink(struct intel_connector *connector)
- static int hdcp2_disable_encryption(struct intel_connector *connector)
- static int hdcp2_enable_encryption(struct intel_connector *connector)
+ static int _intel_hdcp2_disable(struct intel_connector *connector)
+ static int _intel_hdcp2_enable(struct intel_connector *connector)
Commit: drm/i915: Implement HDCP2.2 link integrity check
- ^~~~~~~~~~~~~~~~~~~
- ^~~~~~~~~~~~~~~~~~~~
+ ^~~~~~~~~~~~~~~~~~~~~~
-drivers/gpu/drm/i915/intel_hdcp.c:1495:12: error: ‘_intel_hdcp2_disable’ defined but not used [-Werror=unused-function]
-drivers/gpu/drm/i915/intel_hdcp.c:1509:12: error: ‘_intel_hdcp2_enable’ defined but not used [-Werror=unused-function]
+drivers/gpu/drm/i915/intel_hdcp.c:1599:13: error: ‘intel_hdcp2_check_work’ defined but not used [-Werror=unused-function]
- static int _intel_hdcp2_disable(struct intel_connector *connector)
- static int _intel_hdcp2_enable(struct intel_connector *connector)
+ static void intel_hdcp2_check_work(struct work_struct *work)
Commit: drm/i915: Handle HDCP2.2 downstream topology change
Okay!
Commit: drm/i915: Pullout the bksv read and validation
Okay!
Commit: drm/i915: Initialize HDCP2.2 and its MEI interface
- ^~~~~~~~~~~~~~~~~~~~~~
-cc1: all warnings being treated as errors
-drivers/gpu/drm/i915/intel_hdcp.c:1638:13: error: ‘intel_hdcp2_check_work’ defined but not used [-Werror=unused-function]
-make[1]: *** [drivers/gpu/drm/i915] Error 2
-make[2]: *** [drivers/gpu/drm/i915/intel_hdcp.o] Error 1
-make[2]: *** Waiting for unfinished jobs....
-make: *** [drivers/gpu/drm/] Error 2
- static void intel_hdcp2_check_work(struct work_struct *work)
Commit: drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable
Okay!
Commit: drm/i915: Enable superior HDCP ver that is capable
Okay!
Commit: drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure
Okay!
Commit: drm/i915: hdcp_check_link only on CP_IRQ
Okay!
Commit: drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ
Okay!
Commit: drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
-O:drivers/gpu/drm/i915/intel_i2c.c:403:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_i2c.c:465:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:410:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:410:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:472:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:472:23: warning: expression using sizeof(void)
Commit: drm/i915/gmbus: Enable burst read
-O:drivers/gpu/drm/i915/intel_i2c.c:410:23: warning: expression using sizeof(void)
-O:drivers/gpu/drm/i915/intel_i2c.c:410:23: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:446:31: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:448:31: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/intel_i2c.c:448:31: warning: expression using sizeof(void)
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3664:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3667:16: warning: expression using sizeof(void)
Commit: drm/i915: Implement the HDCP2.2 support for DP
Okay!
Commit: drm/i915: Implement the HDCP2.2 support for HDMI
Okay!
Commit: drm/i915: Add HDCP2.2 support for DP connectors
Okay!
Commit: drm/i915: Add HDCP2.2 support for HDMI connectors
Okay!
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
