✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915: Implement HDCP2.2 (rev5)
URL   : https://patchwork.freedesktop.org/series/38254/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5534d5c8130b drm: hdcp2.2 authentication msg definitions
e1983dd17552 drm: HDMI and DP specific HDCP2.2 defines
05320e361157 mei: bus: whitelist hdcp client
d3a9f111f8e8 misc/mei/hdcp: Client driver for HDCP application
-:85: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

-:102: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#102: FILE: drivers/misc/mei/hdcp/mei_hdcp.c:1:
+/* SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause */

total: 0 errors, 2 warnings, 0 checks, 102 lines checked
631cabacba79 misc/mei/hdcp: Notifier chain for mei cldev state change
-:92: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#92: 
new file mode 100644

-:140: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#140: FILE: include/linux/mei_hdcp.h:44:
+}
+static inline int mei_cldev_unregister_notify(struct notifier_block *nb)

-:144: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#144: FILE: include/linux/mei_hdcp.h:48:
+}
+static inline int mei_cldev_poll_notification(void)

total: 0 errors, 1 warnings, 2 checks, 117 lines checked
8a50ab312a70 misc/mei/hdcp: Define ME FW interface for HDCP2.2
-:22: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

-:186: CHECK:LINE_SPACING: Please don't use multiple blank lines
#186: FILE: drivers/misc/mei/hdcp/mei_hdcp.h:160:
+
+

-:247: CHECK:LINE_SPACING: Please don't use multiple blank lines
#247: FILE: drivers/misc/mei/hdcp/mei_hdcp.h:221:
+
+

-:330: CHECK:LINE_SPACING: Please don't use multiple blank lines
#330: FILE: drivers/misc/mei/hdcp/mei_hdcp.h:304:
+
+

total: 0 errors, 1 warnings, 3 checks, 415 lines checked
84ee35a55af1 linux/mei: Header for mei_hdcp driver interface
6bc980d8e356 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
-:134: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#134: FILE: include/linux/mei_hdcp.h:126:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 106 lines checked
84e76bf55686 misc/mei/hdcp: Verify Receiver Cert and prepare km
-:142: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#142: FILE: include/linux/mei_hdcp.h:140:
 }
+static inline int

total: 0 errors, 0 warnings, 1 checks, 117 lines checked
aefe2ebece44 misc/mei/hdcp: Verify H_prime
-:112: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#112: FILE: include/linux/mei_hdcp.h:152:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 84 lines checked
fd14fdc946e5 misc/mei/hdcp: Store the HDCP Pairing info
-:116: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#116: FILE: include/linux/mei_hdcp.h:161:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 88 lines checked
a654af89f26c misc/mei/hdcp: Initiate Locality check
-:109: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#109: FILE: include/linux/mei_hdcp.h:171:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 84 lines checked
8ae3bad8bfc6 misc/mei/hdcp: Verify L_prime
-:113: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#113: FILE: include/linux/mei_hdcp.h:180:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 85 lines checked
4cc6b45df72b misc/mei/hdcp: Prepare Session Key
-:110: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#110: FILE: include/linux/mei_hdcp.h:188:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 84 lines checked
a907491eeaa8 misc/mei/hdcp: Repeater topology verification and ack
-:133: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#133: FILE: include/linux/mei_hdcp.h:200:
 }
+static inline int

total: 0 errors, 0 warnings, 1 checks, 107 lines checked
9b7ef72365f5 misc/mei/hdcp: Verify M_prime
-:146: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#146: FILE: include/linux/mei_hdcp.h:211:
 }
+static inline

total: 0 errors, 0 warnings, 1 checks, 112 lines checked
9533b0a2bf1d misc/mei/hdcp: Enabling the HDCP authentication
-:112: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#112: FILE: include/linux/mei_hdcp.h:219:
 }
+static inline int mei_enable_hdcp_authentication(struct mei_cl_device *cldev,

total: 0 errors, 0 warnings, 1 checks, 79 lines checked
79bf525e25db misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
-:63: CHECK:LINE_SPACING: Please don't use multiple blank lines
#63: FILE: drivers/misc/mei/hdcp/mei_hdcp.c:716:
+
+

-:108: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#108: FILE: include/linux/mei_hdcp.h:226:
 }
+static inline int mei_close_hdcp_session(struct mei_cl_device *cldev,

total: 0 errors, 0 warnings, 2 checks, 80 lines checked
16767b459033 drm/i915: wrapping all hdcp var into intel_hdcp
-:33: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#33: FILE: drivers/gpu/drm/i915/intel_display.c:15611:
+			cancel_delayed_work_sync(

-:49: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#49: FILE: drivers/gpu/drm/i915/intel_drv.h:390:
+	struct mutex hdcp_mutex;

total: 0 errors, 0 warnings, 2 checks, 265 lines checked
272b58219adc drm/i915: Define HDCP2.2 related variables
faf4862f02e4 drm/i915: Define Intel HDCP2.2 registers
35fa75485b9b drm/i915: Wrappers for mei HDCP2.2 services
-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects?
#30: FILE: drivers/gpu/drm/i915/intel_hdcp.c:18:
+#define GET_MEI_DDI_INDEX(port)		(((port) == PORT_A) ? DDI_A : \
+					 (enum hdcp_physical_port) (port))

-:31: CHECK:SPACING: No space is necessary after a cast
#31: FILE: drivers/gpu/drm/i915/intel_hdcp.c:19:
+					 (enum hdcp_physical_port) (port))

-:109: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#109: FILE: drivers/gpu/drm/i915/intel_hdcp.c:972:
+hdcp2_store_pairing_info(struct intel_hdcp *hdcp,
+			struct hdcp2_ake_send_pairing_info *pairing_info)

-:174: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#174: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1037:
+hdcp2_verify_rep_topology_prepare_ack(

-:210: CHECK:LINE_SPACING: Please don't use multiple blank lines
#210: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1073:
+
+

total: 0 errors, 0 warnings, 5 checks, 207 lines checked
f0b0871219e8 drm/i915: Implement HDCP2.2 receiver authentication
-:222: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#222: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1256:
+	if (!hdcp->is_repeater && shim->config_stream_type) {
+

total: 0 errors, 0 warnings, 1 checks, 196 lines checked
8afdc49b4695 drm/i915: Implement HDCP2.2 repeater authentication
728c6b7de976 drm/i915: Enable and Disable HDCP2.2 port encryption
-:51: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#51: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1417:
+	if (I915_READ(HDCP2_STATUS_DDI(port)) & LINK_AUTH_STATUS) {
+

total: 0 errors, 0 warnings, 1 checks, 66 lines checked
565743b417ff drm/i915: Implement HDCP2.2 En/Dis-able
-:53: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#53: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1477:
+	if (i != tries) {
+

-:95: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#95: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1519:
+		DRM_ERROR("HDCP2 Type%d  Enabling Failed. (%d)\n",
+			   hdcp->content_type, ret);

total: 0 errors, 0 warnings, 2 checks, 84 lines checked
0b9623ddcbbc drm/i915: Implement HDCP2.2 link integrity check
-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1554:
+		DRM_ERROR("HDCP check failed: link is not encrypted, %x\n",
+			   I915_READ(HDCP2_STATUS_DDI(port)));

total: 0 errors, 0 warnings, 1 checks, 107 lines checked
58085107b399 drm/i915: Handle HDCP2.2 downstream topology change
-:45: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#45: FILE: drivers/gpu/drm/i915/intel_hdcp.c:1585:
+		DRM_ERROR("[%s:%d] HDCP2.2 link failed, retrying auth\n",
+			 connector->base.name, connector->base.base.id);

total: 0 errors, 0 warnings, 1 checks, 25 lines checked
478618e93f82 drm/i915: Pullout the bksv read and validation
6d3de0b43294 drm/i915: Initialize HDCP2.2 and its MEI interface
ff7d62cc51ab drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable
0e14bd551f01 drm/i915: Enable superior HDCP ver that is capable
d678fb18b651 drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure
1939a08c60f2 drm/i915: hdcp_check_link only on CP_IRQ
74177819d1de drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ
874606d1c890 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
f478a8f0d9d2 drm/i915/gmbus: Enable burst read
-:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#36: FILE: drivers/gpu/drm/i915/i915_drv.h:2573:
+#define HAS_GMBUS_BURST_READ(dev_priv) (INTEL_GEN(dev_priv) >= 10 || \
+					IS_GEMINILAKE(dev_priv) || \
+					IS_KABYLAKE(dev_priv))

-:50: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#50: FILE: drivers/gpu/drm/i915/i915_reg.h:2999:
+#define   GMBUS_BYTE_CNT_OVERRIDE (1<<6)
                                     ^

-:70: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#70: FILE: drivers/gpu/drm/i915/intel_i2c.c:381:
+	if (burst_read) {
+

total: 0 errors, 0 warnings, 3 checks, 131 lines checked
453c79a01cbe drm/i915: Implement the HDCP2.2 support for DP
-:64: CHECK:LINE_SPACING: Please don't use multiple blank lines
#64: FILE: drivers/gpu/drm/i915/intel_dp.c:5091:
+
+

-:211: CHECK:LINE_SPACING: Please don't use multiple blank lines
#211: FILE: drivers/gpu/drm/i915/intel_dp.c:5449:
+
+

-:223: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#223: FILE: drivers/gpu/drm/i915/intel_dp.c:5461:
+	switch (msg_id) {
+

total: 0 errors, 0 warnings, 3 checks, 410 lines checked
e8112903ee68 drm/i915: Implement the HDCP2.2 support for HDMI
-:122: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#122: FILE: drivers/gpu/drm/i915/intel_hdmi.c:1198:
+	ret = __wait_for(ret = hdcp2_detect_msg_availability(intel_dig_port,
+			 msg_id, &msg_ready, &msg_sz),

total: 0 errors, 0 warnings, 1 checks, 204 lines checked
2515ed3c47a5 drm/i915: Add HDCP2.2 support for DP connectors
9b6826a1a7ce drm/i915: Add HDCP2.2 support for HDMI connectors

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux