✗ Fi.CI.CHECKPATCH: warning for drm/i915/skl+: ddb allocation algorithm optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915/skl+: ddb allocation algorithm optimization
URL   : https://patchwork.freedesktop.org/series/43508/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
73a56949d33f drm/i915/skl+: ddb allocation algorithm optimization
-:51: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#51: FILE: drivers/gpu/drm/i915/intel_pm.c:4289:
+		if (level > max_level || level_wm->min_dbuf_req > plane_ddb
+				      || (level && level_wm->plane_res_l >= 31)

-:52: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#52: FILE: drivers/gpu/drm/i915/intel_pm.c:4290:
+				      || (level && level_wm->plane_res_l >= 31)
+				      || level_wm->plane_res_b == 0) {

-:133: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level < 0'
#133: FILE: drivers/gpu/drm/i915/intel_pm.c:4403:
+	if ((level < 0) || (total_min_blocks > alloc_size)) {

-:133: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'total_min_blocks > alloc_size'
#133: FILE: drivers/gpu/drm/i915/intel_pm.c:4403:
+	if ((level < 0) || (total_min_blocks > alloc_size)) {

-:451: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#451: FILE: drivers/gpu/drm/i915/intel_pm.c:5127:
+		if ((skl_ddb_entry_equal(&cur_ddb->plane[pipe][plane_id],
 					&new_ddb->plane[pipe][plane_id]) &&

-:469: WARNING:LINE_SPACING: Missing a blank line after declarations
#469: FILE: drivers/gpu/drm/i915/intel_pm.c:5145:
+			      struct skl_ddb_allocation *ddb, /* out */
+			      bool *changed /* out */)

total: 0 errors, 1 warnings, 5 checks, 507 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux