Quoting Mika Kuoppala (2017-03-16 09:37:44)
> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
>
> > Compute the offset of the end of the crc32 field using offsetofend()
> > rather than open-coding.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
> > Cc: Zhi Wang <zhi.a.wang@xxxxxxxxx>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
This still applies...
> > ---
> > drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/firmware.c b/drivers/gpu/drm/i915/gvt/firmware.c
> > index 933a7c211a1c..3a5a81fcb406 100644
> > --- a/drivers/gpu/drm/i915/gvt/firmware.c
> > +++ b/drivers/gpu/drm/i915/gvt/firmware.c
> > @@ -159,7 +159,7 @@ static int verify_firmware(struct intel_gvt *gvt,
> >
> > h = (struct gvt_firmware_header *)fw->data;
> >
> > - crc32_start = offsetof(struct gvt_firmware_header, crc32) + 4;
> > + crc32_start = offsetofend(struct gvt_firmware_header, crc32);
> > mem = fw->data + crc32_start;
> >
> > #define VERIFY(s, a, b) do { \
> > --
> > 2.11.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
