Re: [PATCH 1/2] drm/i915: split CNL platforms in GT1/2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lionel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.17-rc5 next-20180516]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-split-CNL-platforms-in-GT1-2/20180516-174705
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   arch/x86/kernel/early-quirks.c:533:9: sparse: undefined identifier 'INTEL_CNL_IDS'
>> arch/x86/kernel/early-quirks.c:533:22: sparse: not a function <noident>
   arch/x86/kernel/early-quirks.c:613:49: sparse: restricted pci_power_t degrades to integer
   arch/x86/kernel/early-quirks.c:619:57: sparse: restricted pci_power_t degrades to integer
   arch/x86/kernel/early-quirks.c:533:2: error: implicit declaration of function 'INTEL_CNL_IDS'; did you mean 'INTEL_CFL_IDS'? [-Werror=implicit-function-declaration]
     INTEL_CNL_IDS(&gen9_early_ops),
     ^~~~~~~~~~~~~
     INTEL_CFL_IDS
   arch/x86/kernel/early-quirks.c:533:2: error: initializer element is not constant
   arch/x86/kernel/early-quirks.c:533:2: note: (near initialization for 'intel_early_ids[207].vendor')
   arch/x86/kernel/early-quirks.c:503:67: warning: missing braces around initializer [-Wmissing-braces]
    static const struct pci_device_id intel_early_ids[] __initconst = {
                                                                      ^
   arch/x86/kernel/early-quirks.c:533:2:
     INTEL_CNL_IDS(&gen9_early_ops),
     {
    };
    }
   cc1: some warnings being treated as errors

vim +533 arch/x86/kernel/early-quirks.c

3e3b2c390 Damien Lespiau  2014-05-08  502  
ee0629cfd Joonas Lahtinen 2016-04-22  503  static const struct pci_device_id intel_early_ids[] __initconst = {
ee0629cfd Joonas Lahtinen 2016-04-22  504  	INTEL_I830_IDS(&i830_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  505  	INTEL_I845G_IDS(&i845_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  506  	INTEL_I85X_IDS(&i85x_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  507  	INTEL_I865G_IDS(&i865_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  508  	INTEL_I915G_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  509  	INTEL_I915GM_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  510  	INTEL_I945G_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  511  	INTEL_I945GM_IDS(&gen3_early_ops),
8d9c20e1d Carlos Santa    2016-08-17  512  	INTEL_VLV_IDS(&gen6_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  513  	INTEL_PINEVIEW_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  514  	INTEL_I965G_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  515  	INTEL_G33_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  516  	INTEL_I965GM_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  517  	INTEL_GM45_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  518  	INTEL_G45_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  519  	INTEL_IRONLAKE_D_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  520  	INTEL_IRONLAKE_M_IDS(&gen3_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  521  	INTEL_SNB_D_IDS(&gen6_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  522  	INTEL_SNB_M_IDS(&gen6_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  523  	INTEL_IVB_M_IDS(&gen6_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  524  	INTEL_IVB_D_IDS(&gen6_early_ops),
8d9c20e1d Carlos Santa    2016-08-17  525  	INTEL_HSW_IDS(&gen6_early_ops),
8d9c20e1d Carlos Santa    2016-08-17  526  	INTEL_BDW_IDS(&gen8_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  527  	INTEL_CHV_IDS(&chv_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  528  	INTEL_SKL_IDS(&gen9_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  529  	INTEL_BXT_IDS(&gen9_early_ops),
ee0629cfd Joonas Lahtinen 2016-04-22  530  	INTEL_KBL_IDS(&gen9_early_ops),
33aa69ed8 Lucas De Marchi 2017-12-13  531  	INTEL_CFL_IDS(&gen9_early_ops),
bc384c77e Paulo Zanoni    2017-01-24  532  	INTEL_GLK_IDS(&gen9_early_ops),
2e1e9d489 Paulo Zanoni    2017-07-05 @533  	INTEL_CNL_IDS(&gen9_early_ops),
814c5f1f5 Jesse Barnes    2013-07-26  534  };
814c5f1f5 Jesse Barnes    2013-07-26  535  

:::::: The code at line 533 was first introduced by commit
:::::: 2e1e9d48939edad49a9f06762ecfc9c73666d489 x86/gpu: CNL uses the same GMS values as SKL

:::::: TO: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
:::::: CC: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux