== Series Details == Series: Add ChromeOS EC CEC Support (rev2) URL : https://patchwork.freedesktop.org/series/43162/ State : warning == Summary == $ dim checkpatch origin/drm-tip e778f6269fef media: cec-notifier: Get notifier by device and connector name -:72: WARNING:NEEDLESS_IF: kfree(NULL) is safe and this check is probably not required #72: FILE: drivers/media/cec/cec-notifier.c:70: + if (n->conn) + kfree(n->conn); total: 0 errors, 1 warnings, 0 checks, 100 lines checked f50a086de9ef drm/i915: hdmi: add CEC notifier to intel_hdmi -:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate total: 0 errors, 1 warnings, 0 checks, 55 lines checked 17b6a8346a1c mfd: cros-ec: Introduce CEC commands and events definitions. -:196: ERROR:SPACING: space required after that close brace '}' #196: FILE: include/linux/mfd/cros_ec_commands.h:2897: +}__packed; total: 1 errors, 0 warnings, 0 checks, 180 lines checked c1790718f6c3 mfd: cros_ec_dev: Add CEC sub-device registration a117274c46c0 media: platform: Add Chrome OS EC CEC driver -:28: WARNING:CONFIG_DESCRIPTION: prefer 'help' over '---help---' for new help texts #28: FILE: drivers/media/platform/Kconfig:549: +config VIDEO_CROS_EC_CEC -:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 -:139: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #139: FILE: drivers/media/platform/cros-ec-cec/cros-ec-cec.c:75: +static int cros_ec_cec_event(struct notifier_block *nb, + unsigned long queued_during_suspend, void *_notify) -:203: WARNING:TYPO_SPELLING: 'writting' may be misspelled - perhaps 'writing'? #203: FILE: drivers/media/platform/cros-ec-cec/cros-ec-cec.c:139: + "error writting CEC msg on EC: %d\n", ret); -:270: CHECK:LINE_SPACING: Please don't use multiple blank lines #270: FILE: drivers/media/platform/cros-ec-cec/cros-ec-cec.c:206: + + -:369: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #369: FILE: drivers/media/platform/cros-ec-cec/cros-ec-cec.c:305: + ret = blocking_notifier_chain_unregister( total: 0 errors, 3 warnings, 3 checks, 359 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
