✗ Fi.CI.CHECKPATCH: warning for Add ChromeOS EC CEC Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Add ChromeOS EC CEC Support
URL   : https://patchwork.freedesktop.org/series/43162/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f0dc064a3cc9 mfd: cros_ec_dev: Add CEC sub-device registration
a596dfa2f304 media: cec-notifier: Get notifier by device and connector name
baa482463e7a drm/i915: hdmi: add CEC notifier to intel_hdmi
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate

total: 0 errors, 1 warnings, 0 checks, 48 lines checked
364a2f79ce3d mfd: cros-ec: Introduce CEC commands and events definitions.
-:196: ERROR:SPACING: space required after that close brace '}'
#196: FILE: include/linux/mfd/cros_ec_commands.h:2897:
+}__packed;

total: 1 errors, 0 warnings, 0 checks, 180 lines checked
ff97617cef82 media: platform: Add Chrome OS EC CEC driver
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
When the logical address is invalid, the controller will act as a CEC sniffer

-:28: WARNING:CONFIG_DESCRIPTION: prefer 'help' over '---help---' for new help texts
#28: FILE: drivers/media/platform/Kconfig:549:
+config VIDEO_CROS_EC_CEC

-:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

-:131: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#131: FILE: drivers/media/platform/cros-ec/cros-ec-cec.c:67:
+static int cros_ec_cec_event(struct notifier_block *nb,
+	unsigned long queued_during_suspend, void *_notify)

-:203: WARNING:TYPO_SPELLING: 'writting' may be misspelled - perhaps 'writing'?
#203: FILE: drivers/media/platform/cros-ec/cros-ec-cec.c:139:
+			"error writting CEC msg on EC: %d\n", ret);

-:270: CHECK:LINE_SPACING: Please don't use multiple blank lines
#270: FILE: drivers/media/platform/cros-ec/cros-ec-cec.c:206:
+
+

-:364: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#364: FILE: drivers/media/platform/cros-ec/cros-ec-cec.c:300:
+	ret = blocking_notifier_chain_unregister(

total: 0 errors, 4 warnings, 3 checks, 354 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux