On 2018.05.10 16:17:35 +0100, Matthew Auld wrote:
> > @@ -934,6 +944,20 @@ static int ppgtt_invalidate_spt(struct intel_vgpu_ppgtt_spt *spt)
> > return ret;
> > }
> >
> > +static bool vgpu_ips_enabled(struct intel_vgpu *vgpu)
> > +{
> > + if (INTEL_GEN(vgpu->gvt->dev_priv) == 9) {
> > + u32 ips = vgpu_vreg_t(vgpu, GEN8_GAMW_ECO_DEV_RW_IA) &
> > + GAMW_ECO_ENABLE_64K_IPS_FIELD;
> > +
> > + return ips == GAMW_ECO_ENABLE_64K_IPS_FIELD;
> > + } else if (INTEL_GEN(vgpu->gvt->dev_priv) >= 10) {
> > + /* 64K paging only controlled by IPS bit in PTE now. */
> > + return true;
>
> AFAIK the funny business with having to enable the IPS bit through
> mmio is also needed on GEN10.
yeah, looks it only won't be needed from Gen11.
Thanks for review! Will update that.
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
