On Tue, Aug 21, 2012 at 09:20:37AM +0200, Daniel Vetter wrote: > On Mon, Aug 13, 2012 at 08:07:43AM +0000, Xu, Anhua wrote: > > Hi, Paul > > > > Thanks for your advice. I update my patch. Please review, for your question, please see my reply below. > > > > From d11080eda81c0503b5035ea40667b06fe2ee0fb5 Mon Sep 17 00:00:00 2001 > > From: Anhua Xu <anhua.xu at intel.com> > > Date: Tue, 31 Jul 2012 17:16:50 +0800 > > Subject: [PATCH v3] drm/i915: fix wrong order of parameters in port checking functions > > > > Wrong order of parameters passed-in when calling hdmi/adpa > > /lvds_pipe_enabled(), 2nd and 3rd parameters are reversed. > > This bug was indroduced by below commit: > > > > commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37 > > Author: Keith Packard <keithp at keithp.com> > > Date: Sat Aug 6 10:35:34 2011 -0700 > > > > drm/i915: Fix PCH port pipe select in CPT disable paths > > > > The reachable tag for this commit is v3.1-rc1-3-g1519b99 > > > > Signed-off-by: Anhua Xu <anhua.xu at intel.com> > > Acked-by: Paul Menzel <paulepanter at users.sourceforge.net> > > I've just remembered that we have a bug report that bisects to the above > commit: > > https://bugs.freedesktop.org/show_bug.cgi?id=44876 And this does indeeed fix the bug! I've moved the patch to -fixes, with cc stable added. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48