On Tue, 31 Jul 2012 02:29:01 +0000, "Xu, Anhua" <anhua.xu at intel.com> wrote: > Hi, I found some bugs in i915 driver when reviewing intel_display.c The parameter passed-in for function hdmi/adpa/lvds_pipe_enabled() are not coherent with functions' definition. > This is the patch. Patch looks good, you might want to mention that the regression was introduced with commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37. Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre