Re: [PATCH] drm/i915/selftests: Only switch to kernel context when locked

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> In igt_flush_test() we try to switch back to the kernel context, but we
> are only able to do so when we care called with struct_mutex held.

s/care/are

>
> More CI fallout from lockdep being temporarily suppressed :(

Kind words.../o\

Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

>
> Fixes: 4cdf65ce8cc2 ("drm/i915/selftests: Return to kernel context after each test")
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/selftests/igt_flush_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/igt_flush_test.c b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
> index 7f35bddc2e95..0d06f559243f 100644
> --- a/drivers/gpu/drm/i915/selftests/igt_flush_test.c
> +++ b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
> @@ -57,7 +57,8 @@ int igt_flush_test(struct drm_i915_private *i915, unsigned int flags)
>  
>  	cond_resched();
>  
> -	if (i915_gem_switch_to_kernel_context(i915)) {
> +	if (flags & I915_WAIT_LOCKED &&
> +	    i915_gem_switch_to_kernel_context(i915)) {
>  		pr_err("Failed to switch back to kernel context; declaring wedged\n");
>  		i915_gem_set_wedged(i915);
>  	}
> -- 
> 2.17.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux