Re: [PATCH 2/2] drm/i915/selftests: Flush GPU activity before completing live_contexts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Mika Kuoppala (2018-05-08 12:38:40)
> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:
> 
> > igt_ctx_exec() expects that we retire all active requests/objects before
> > completing, so that when we clean up the files afterwards they are ready
> > to be freed. Before we do so, it is then prudent to ensure that we have
> > indeed retired the GPU activity, raising an error if it fails. If we do
> > not, we run the risk of triggering an assertion when freeing the object:
> >
> >   __i915_gem_free_objects:4793 GEM_BUG_ON(i915_gem_object_is_active(obj))
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

Much appreciated; those purple CI blobs kept worrying me. "I thought I
fixed this already!" ;)

Pushed,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux