Quoting Mika Kuoppala (2018-05-07 17:52:18) > We use a pattern of wmb() along with ggtt_invalidate. > Move the wmb out from call sites into the ggtt_invalidate > as it is part of invalidation. > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Matthew Auld <matthew.auld@xxxxxxxxx> > Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> If we take this and the last which look at ggtt together, then Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> I've a persistent dread when it comes to write through the GTT itself, as different wc buffers seem to mess up aliasing, but this should be simple wc vs uc mmio, so playing by concrete rules. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx