On Sun, 06 May 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Unsafe module parameters are just that, unsafe. If the user is foolish > enough to try them and the kernel breaks, they get to keep both pieces. > Don't ask them to file a bug report if they broke it themselves. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=106423 > Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure injection") > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Imre Deak <imre.deak@xxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_drv.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 9b782045ae17..9c449b8d8eab 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -101,7 +101,13 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level, > __builtin_return_address(0), &vaf); > > if (is_error && !shown_bug_once) { > - dev_notice(kdev, "%s", FDO_BUG_MSG); > + /* > + * Ask the user to file a bug report for the error, except > + * if they may have caused the bug by fiddling with unsafe > + * module parameters. > + */ > + if (!test_taint(TAINT_USER)) > + dev_notice(kdev, "%s", FDO_BUG_MSG); > shown_bug_once = true; > } -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
