Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Daniel Vetter (2018-05-04 09:23:01)
> On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote:
> > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote:
> > > Quoting Daniel Vetter (2018-05-03 15:25:52)
> > > > Almost everyone uses dma_fence_default_wait.
> > > > 
> > > > v2: Also remove the BUG_ON(!ops->wait) (Chris).
> > > 
> > > I just don't get the rationale for implicit over explicit.
> > 
> > Closer approximation of dwim semantics. There's been tons of patch series
> > all over drm and related places to get there, once we have a big pile of
> > implementations and know what the dwim semantics should be. Individually
> > they're all not much, in aggregate they substantially simplify simple
> > drivers.
> 
> I also think clearer separation between optional optimization hooks and
> mandatory core parts is useful in itself.

A new spelling of midlayer ;) I don't see the contradiction with a
driver saying use the default and simplicity. (I know which one the
compiler thinks is simpler ;)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux