Re: [PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Jani Nikula (2018-05-03 09:58:17)
> On Wed, 02 May 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> > Quoting Chris Wilson (2018-04-09 10:54:46)
> >> Quoting Chris Wilson (2018-04-09 10:49:05)
> >> > If we try to suspend a wedged device following a GPU reset failure, we
> >> > will also fail to turn off the rc6 powerwells (on vlv), leading to a
> >> > *ERROR*. This is quite expected in this case, so the best we can do is
> >> > shake our heads and reduce the *ERROR* to a debug so CI stops
> >> > complaining.
> >> > 
> >> > Testcase: igt/gem_eio/in-flight-suspend #vlv
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105583
> >
> > Does anyone want to keep this *ERROR* that we can trigger at will?
> 
> No strong feelings. I guess my question is, can this happen when there's
> no GPU reset failures, and the change would silence that?

It hasn't occurred yet, but we see reset failures in the wild (just not
on byt afair). From the code pov, it is marked as a debug feature and
called before system suspend, so should be harmless (famous last words).
 
> Anyway, if it makes CI less noisy,
> 
> Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux