Quoting Lionel Landwerlin (2018-04-30 15:37:42)
> On 25/04/18 12:50, Chris Wilson wrote:
> > Quoting Lionel Landwerlin (2018-04-25 12:45:14)
> >> This function will be used later by the per (context,engine) power
> >> programming interface.
> > No. This is not the appropriate uABI, please see
> > intel_engine_lookup_user().
> > -Chris
> >
> uAPI wise, does this sound okay? :
>
> #define I915_CONTEXT_PARAM_SSEU 0x7
> __u64 value;
>
> struct drm_i915_gem_context_param_sseu {
> /*
> * Engine to be configured or queried.
> */
> __u32 class;
> __u32 instance;
Tvrtko hasn't yet complained about me limiting class/instance to
U32_MAX, so I think this limit will do for the forseeable future ;)
> /*
> * Setting slice_mask or subslice_mask to 0 will make the
> context use
> * masks reported respectively by I915_PARAM_SLICE_MASK or
> * I915_PARAM_SUBSLICE_MASK.
> */
> union {
> struct {
> __u8 slice_mask;
> __u8 subslice_mask;
> __u8 min_eus_per_subslice;
> __u8 max_eus_per_subslice;
> } packed;
> __u64 value;
> };
The union isn't required any more as we aren't packing into the u64
value.
I would include perhaps a rsvd field? And then make the interface accept
an array of these.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
