Quoting Michał Winiarski (2018-04-26 17:21:39)
> On Wed, Apr 11, 2018 at 01:03:46PM +0100, Chris Wilson wrote:
> > Even though we weren't injecting guilty requests to be reset, we could
> > still fall over the issue of resetting the same request too fast -- where
> > the GPU refuses to start again. (Although it is interesting to note that
> > reloading the driver is sufficient, suggesting that we could recover if
> > we delayed the setup after reset?) Continue to paper over the problem by
> > adding a small delay by waiting for the engine to idle between tests,
> > and ensure that the engines are idle before starting the idle tests.
> >
> > References: 028666793a02 ("drm/i915/selftests: Avoid repeatedly harming the same innocent context")
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
> > Cc: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> > Cc: Michel Thierry <michel.thierry@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > ---
> > .../gpu/drm/i915/selftests/intel_hangcheck.c | 48 ++++++++++++++++++-
> > 1 file changed, 47 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> > index 24f913f26a7b..7e23e6a6719c 100644
> > --- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> > +++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> > @@ -454,6 +454,11 @@ static int igt_global_reset(void *arg)
> > return err;
> > }
> >
>
> #define IGT_IDLE_TIMEOUT 50 ?
> It should even fit within a line.
>
> With or without that:
>
> Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>
Done. Thanks for the review, pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
