>-----Original Message----- >From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx] >Sent: Wednesday, April 18, 2018 8:44 PM >To: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>; Shi, Yang A <yang.a.shi@xxxxxxxxx>; >intel-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: Shi, Yang A <yang.a.shi@xxxxxxxxx> >Subject: Re: [PATCH] drm/i915: Refine the has_audio assignment > >On Fri, 13 Apr 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: >> Quoting Yang (2018-04-13 05:06:45) >>> From: Yang Shi <yang.a.shi@xxxxxxxxx> >>> >>> Refine the has_audio assignment for dp and hdmi. >> >> s/Refine/Ignore the user override for/ >> >> Why? > >Yang, we'll need the explanation before we continue with review or even consider >merging. We routinely ignore patches where questions go unanswered. > >BR, >Jani. This code change is just to make driver code more readable. If(condition) value = a else value = condition looks redundancy. BR. Yang. > > >-- >Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
