Quoting Michal Wajdeczko (2018-04-14 16:59:13) > On Sat, 14 Apr 2018 11:12:33 +0200, Chris Wilson > <chris@xxxxxxxxxxxxxxxxxx> wrote: > > > We have to cleanup after i915_perf_init(), even on the error path, as it > > passes a pointer into the module to the sysfs core. If we fail to > > unregister the sysctl table, we leave a dangling pointer which then may > > explode anytime later the sysctl table, we leave a dangling pointer > > which then may explode anytime later. > > no need to repeat, we're smart enough to get it after first time ;) Smarter than me for sure, I didn't even notice I hit '.' too late. Fixed up the commitmsg and old comment style, and pushed (and forgot to say I pushed). Thanks all for the review, -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx