On Tue, 17 Apr 2018, Gaurav K Singh <gaurav.k.singh@xxxxxxxxx> wrote: > On Geminilake, sometimes audio card is not getting > detected after reboot. This is a spurious issue happening on > Geminilake. HW codec and HD audio controller link was going > out of sync for which there was a fix in i915 driver but > was not getting invoked for GLK. Extending this fix to GLK as well. > > Tested by Du,Wenkai on GLK board. > > Bspec: 21829 > > v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro > > Signed-off-by: Gaurav K Singh <gaurav.k.singh@xxxxxxxxx> > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> That Reviewed-by is jumping to conclusions I'm afraid. Giving review comments does not mean Reviewed-by. Only explicit Reviewed-by reply does. I can only say that this is the right approach *if* glk is to be covered here, but I have no data to actually say if that's the right thing to do. BR, Jani. > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index 656f6c931341..3ea566f99450 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev, > struct drm_i915_private *dev_priv = kdev_to_i915(kdev); > u32 tmp; > > - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv)) > + if (!IS_GEN9(dev_priv)) > return; > > i915_audio_component_get_power(kdev); -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
